Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor code generation #65

Merged
merged 13 commits into from
Sep 8, 2023
Merged

Refactor code generation #65

merged 13 commits into from
Sep 8, 2023

Conversation

azazeal
Copy link
Contributor

@azazeal azazeal commented Aug 28, 2023 •
edited
Loading

This PR refactors the codebase in order to address our internal build issue. It additionally adds checks to the Makefile that ensure that code is generated via suitable versions of protoc-gen-go and protoc-gen-go-grpc.

@azazeal azazeal changed the title Refactor generated packages names Refactor proto packages names Aug 28, 2023
@maraino
Copy link
Contributor

maraino commented Aug 28, 2023 •
edited
Loading

A change like this might cause backward incompatibility problems between open-source step-ca and majordomo. Although we don't have EAB support, it might work. But we would need to test it.

maraino
maraino reviewed Sep 5, 2023
View reviewed changes
majordomo_grpc.pb.go Outdated Show resolved Hide resolved
@azazeal azazeal changed the title Refactor proto packages names Refactor code generation Sep 6, 2023
@azazeal azazeal marked this pull request as ready for review September 6, 2023 13:48
@azazeal azazeal requested a review from a team as a code owner September 6, 2023 13:48
@azazeal azazeal marked this pull request as draft September 6, 2023 16:01
maraino
maraino requested changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine, but I've added a couple of suggestions to be able to run make generate.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
azazeal and others added 2 commits September 7, 2023 21:53
@azazeal @maraino
reworked awk flags #1
a6fa5a5 
Co-authored-by: Mariano Cano <mariano@smallstep.com>
@azazeal @maraino
reworked awk flags #2
13e1ec9 
Co-authored-by: Mariano Cano <mariano@smallstep.com>
@azazeal azazeal marked this pull request as ready for review September 7, 2023 18:56
@azazeal azazeal requested review from maraino and a team September 7, 2023 18:57
@azazeal azazeal merged commit b02f24e into main Sep 8, 2023
12 checks passed
@azazeal azazeal deleted the panos/majordomo branch September 8, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azazeal @maraino